Changeset 226 for trunk/EventBenchConsole

Timestamp:

09/30/11 18:00:55 (13 years ago)

Author:

sherbold

Message:

• fixed a couple of code smells

Location:

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench

Files:

• commands/CMDshowSequences.java (modified) (1 diff)
• swing/DlgInsert.java (modified) (1 diff)
• swt/CommandHistoryDialog.java (modified) (1 diff)
• swt/GenerateSequencesDialog.java (modified) (1 diff)
• web/commands/CMDloadSessionsFromClickstream.java (modified) (2 diffs)
• web/data/WebRequest.java (modified) (2 diffs)
• windows/EventGenerator.java (modified) (1 diff)

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/commands/CMDshowSequences.java

@@ -29 +29 @@
                                         .getInstance().getData("sequences");
                 } catch (ClassCastException e) {
-                        Console.println("Not able to cast Data in GlobalDataContainer to List of Sequences");
+                        Console.println("Unable to cast Data in GlobalDataContainer to List of Sequences");
                 }
 

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swing/DlgInsert.java

@@ -405 +405 @@
                         Enumeration<DefaultMutableTreeNode> e = node.children(); e
                                         .hasMoreElements();) {
-                                TreeNode n = (TreeNode) e.nextElement();
+                                TreeNode n = e.nextElement();
                                 TreePath path = parent.pathByAddingChild(n);
                                 expandAll(tree, path, expand);

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swt/CommandHistoryDialog.java

@@ -145 +145 @@
                                                                 + filename);
                                                 Console.logException(e);
+                                                return;
                                         }
                                         try {

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swt/GenerateSequencesDialog.java

@@ -104 +104 @@
                 grpIterations.setLayout(new GridLayout(1, false));
                 grpIterations.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false, 2, 1));
-                grpIterations.setText("Iterations");;
+                grpIterations.setText("Iterations");
                 
                 iterationsSpinner = new Spinner(grpIterations, SWT.BORDER);

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web/commands/CMDloadSessionsFromClickstream.java

@@ -34 +34 @@
                 String source = (String) parameters.get(0);
                 String sequencesName = (String) parameters.get(1);
-                String serverUrl = "";
+                String serverUrl = null;
                 int timeout = -1;
                 int minLength = -1;
@@ -48 +48 @@
 
                 WeblogParser parser = new WeblogParser();
-                if( serverUrl!="" ) {
+                if( serverUrl!=null ) {
                         parser.setUrl(serverUrl);
                 }

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web/data/WebRequest.java

@@ -94 +94 @@
                                         isFirstPost = false;
                                 } else {
-                                        builder.append("&");
+                                        builder.append('&');
                                 }
                                 builder.append(postVar + "=DATA_" + postVar.toUpperCase()
                                                 + "_DATA");
                         }
-                        builder.append("\"");
+                        builder.append('\"');
                 }
-                builder.append(" ");
+                builder.append(' ');
                 if (serverUrl != null) {
                         builder.append(serverUrl);
@@ -110 +110 @@
                         for (String getVar : getVars) {
                                 if (isFirstGet) {
-                                        builder.append("?");
+                                        builder.append('?');
                                         isFirstGet = false;
                                 } else {
-                                        builder.append("&");
+                                        builder.append('&');
                                 }
                                 builder.append(getVar + "=DATA_" + getVar.toUpperCase()

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/windows/EventGenerator.java

@@ -52 +52 @@
                         rulesNamespace = Namespace.getNamespace("ul:rules");
                 } catch (JDOMException e) {
-                        System.err.println("Invalid rules file.");
+                        Console.printerrln("Invalid rules file.");
                         e.printStackTrace();
                 } catch (IOException e) {
-                        System.err.println("Invalid rules file.");
+                        Console.printerrln("Invalid rules file.");
                         e.printStackTrace();
                 }