Changeset 226 for trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web

Timestamp:

09/30/11 18:00:55 (13 years ago)

Author:

sherbold

Message:

• fixed a couple of code smells

Location:

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web

Files:

• commands/CMDloadSessionsFromClickstream.java (modified) (2 diffs)
• data/WebRequest.java (modified) (2 diffs)

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web/commands/CMDloadSessionsFromClickstream.java

@@ -34 +34 @@
                 String source = (String) parameters.get(0);
                 String sequencesName = (String) parameters.get(1);
-                String serverUrl = "";
+                String serverUrl = null;
                 int timeout = -1;
                 int minLength = -1;
@@ -48 +48 @@
 
                 WeblogParser parser = new WeblogParser();
-                if( serverUrl!="" ) {
+                if( serverUrl!=null ) {
                         parser.setUrl(serverUrl);
                 }

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web/data/WebRequest.java

@@ -94 +94 @@
                                         isFirstPost = false;
                                 } else {
-                                        builder.append("&");
+                                        builder.append('&');
                                 }
                                 builder.append(postVar + "=DATA_" + postVar.toUpperCase()
                                                 + "_DATA");
                         }
-                        builder.append("\"");
+                        builder.append('\"');
                 }
-                builder.append(" ");
+                builder.append(' ');
                 if (serverUrl != null) {
                         builder.append(serverUrl);
@@ -110 +110 @@
                         for (String getVar : getVars) {
                                 if (isFirstGet) {
-                                        builder.append("?");
+                                        builder.append('?');
                                         isFirstGet = false;
                                 } else {
-                                        builder.append("&");
+                                        builder.append('&');
                                 }
                                 builder.append(getVar + "=DATA_" + getVar.toUpperCase()