Changeset 284 for trunk/EventBenchConsole/src/de/ugoe/cs/eventbench

Timestamp:

12/09/11 11:22:08 (13 years ago)

Author:

sherbold

Message:

• fixed some code smells

Location:

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench

Files:

• commands/CMDshowTimer.java (modified) (1 diff)
• swing/DlgInsert.java (modified) (2 diffs)
• web/data/WebEvent.java (modified) (1 diff)

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/commands/CMDshowTimer.java

@@ -33 +33 @@
                 }
 
-                Object dataObject = (Long) GlobalDataContainer.getInstance().getData(
-                                timerName);
+                Object dataObject = GlobalDataContainer.getInstance().getData(timerName);
                 if (dataObject == null) {
                         CommandHelpers.objectNotFoundMessage(timerName);

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swing/DlgInsert.java

@@ -512 +512 @@
                 }
                 // TextEquals
-                else if (selectedItem == "TextEquals") {
+                else if (selectedItem.equals("TextEquals")) {
                         if (textFieldExpectedValue.getText().length() == 0) {
                                 JOptionPane.showMessageDialog(null,
@@ -539 +539 @@
 
                                 // get all parents
-                                String target = "";
+                                StringBuilder target = new StringBuilder();
                                 for (int i = 0; i < splitted.length; i++) {
-                                        target += splitted[i];
+                                        target.append(splitted[i]);
                                 }
                                 // ***
 
-                                TextEqualsReplay text = new TextEqualsReplay(textFieldExpectedValue.getText(),target);
+                                TextEqualsReplay text = new TextEqualsReplay(textFieldExpectedValue.getText(),target.toString());
 
                                 AssertEvent<TextEqualsReplay> e = new AssertEvent<TextEqualsReplay>(

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/web/data/WebEvent.java

@@ -89 +89 @@
         }
 
+        /*
+         * (non-Javadoc)
+         * 
+         * @see de.ugoe.cs.eventbench.data.ReplayableEvent#equals(java.lang.Object)
+         */
+        @Override
+        public boolean equals(Object other) {
+                return super.equals(other);
+        }
+
+        /*
+         * (non-Javadoc)
+         * 
+         * @see de.ugoe.cs.eventbench.data.ReplayableEvent#hashCode()
+         */
+        @Override
+        public int hashCode() {
+                return super.hashCode();
+        }
+
 }