Changeset 371 for trunk

Timestamp:

01/30/12 14:07:12 (13 years ago)

Author:

sherbold

Message:

• JFCMonitor monitors KEY_PRESSED and KEY_RELEASED instead of KEY_TYPED events, because of various drawbacks of key typed (does not receive all inputs, like pressing enter and the events only offer the actual char pressed, not its virtual code, which leads to all kinds of problems, e.g., in case of backspace)

Location:

trunk/JFCMonitor/src/de/ugoe/cs/eventbench/jfcmonitor

Files:

• JFCListener.java (modified) (4 diffs)
• Runner.java (modified) (1 diff)

trunk/JFCMonitor/src/de/ugoe/cs/eventbench/jfcmonitor/JFCListener.java

@@ -66 +66 @@
                         MouseEvent mouseEvent = (MouseEvent) event;
                         if (!isMouseMovement(event.getID())) {
-                                builder.append("<event id=\"" + event.getID() + "\">" + StringTools.ENDLINE);
+                                builder.append("<event id=\"" + event.getID() + "\">"
+                                                + StringTools.ENDLINE);
                                 builder.append(" <param name=\"X\" value=\""
                                                 + mouseEvent.getX() + "\" />" + StringTools.ENDLINE);
@@ -72 +73 @@
                                                 + mouseEvent.getY() + "\" />" + StringTools.ENDLINE);
                                 builder.append(" <param name=\"Button\" value=\""
-                                                + mouseEvent.getButton() + "\" />" + StringTools.ENDLINE);
+                                                + mouseEvent.getButton() + "\" />"
+                                                + StringTools.ENDLINE);
                                 builder.append(" <param name=\"Modifiers\" value=\""
-                                                + mouseEvent.getModifiers() + "\" />" + StringTools.ENDLINE);
+                                                + mouseEvent.getModifiers() + "\" />"
+                                                + StringTools.ENDLINE);
                                 addSourceInfo(builder, event);
                                 builder.append("</event>" + StringTools.ENDLINE);
@@ -81 +84 @@
                 if (event instanceof KeyEvent) {
                         KeyEvent keyEvent = (KeyEvent) event;
-                        if (keyEvent.getID() == KeyEvent.KEY_TYPED) {
-                                builder.append("<event id=\"" + event.getID() + "\">" + StringTools.ENDLINE);
+                        if (keyEvent.getID() == KeyEvent.KEY_PRESSED
+                                        || keyEvent.getID() == KeyEvent.KEY_RELEASED) {
+                                builder.append("<event id=\"" + event.getID() + "\">"
+                                                + StringTools.ENDLINE);
                                 builder.append(" <param name=\"KeyCode\" value=\""
                                                 + keyEvent.getKeyCode() + "\" />" + StringTools.ENDLINE);
                                 builder.append(" <param name=\"Modifiers\" value=\""
-                                                + keyEvent.getModifiers() + "\" />" + StringTools.ENDLINE);
+                                                + keyEvent.getModifiers() + "\" />"
+                                                + StringTools.ENDLINE);
                                 addSourceInfo(builder, event);
                                 builder.append("</event>" + StringTools.ENDLINE);
@@ -93 +99 @@
                 if (event instanceof FocusEvent) {
                         FocusEvent focusEvent = (FocusEvent) event;
-                        if( focusEvent.getID() == FocusEvent.FOCUS_GAINED ) {
-                                builder.append("<event id=\"" + event.getID() + "\">" + StringTools.ENDLINE);
+                        if (focusEvent.getID() == FocusEvent.FOCUS_GAINED) {
+                                builder.append("<event id=\"" + event.getID() + "\">"
+                                                + StringTools.ENDLINE);
                                 addSourceInfo(builder, event);
                                 builder.append("</event>" + StringTools.ENDLINE);

trunk/JFCMonitor/src/de/ugoe/cs/eventbench/jfcmonitor/Runner.java

@@ -78 +78 @@
                                 Toolkit.getDefaultToolkit().addAWTEventListener(listenerStdOut,
                                                 AWTEvent.MOUSE_EVENT_MASK);
+                                Toolkit.getDefaultToolkit().addAWTEventListener(listenerStdOut,
+                                                FocusEvent.FOCUS_EVENT_MASK);
                         } catch (UnsupportedEncodingException e) {
                                 System.err